Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Updates version of order-already gem #2334

Merged
merged 1 commit into from
Sep 19, 2024
Merged

🧹 Updates version of order-already gem #2334

merged 1 commit into from
Sep 19, 2024

Conversation

sjproctor
Copy link
Collaborator

Ref:

This commit updates the version of the order-already gem to 0.3.2. This version of the gem handles blank values preventing blank fields from being assigned [""] instead of [].

@samvera/hyku-code-reviewers

@sjproctor sjproctor added the patch-ver for release notes label Sep 19, 2024
orangewolf
orangewolf requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should have a lockfile update as well

ShanaLMoore
ShanaLMoore previously requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@ShanaLMoore ShanaLMoore left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit the Gemfile.lock as well. Without it the gem version won't actually be changed.

Update: Sorry, disregard. I didn't notice Rob already reviewed and commented!! Holler if you need help.

@ShanaLMoore ShanaLMoore dismissed their stale review September 19, 2024 19:25

Ron already reviewed this.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Test Results

    3 files  ±0      3 suites  ±0   18m 2s ⏱️ -31s
2 036 tests ±0  1 986 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 063 runs  ±0  2 011 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit 947c483. ± Comparison against base commit dac6f86.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both. 
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 1f36c78e-eb2e-4e2e-a5d1-4b19a713c521
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 95bede3c-f526-4730-84e3-46d9eb76fb6f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 1cf10b13-c622-4e49-8c11-c995e685ab00
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update ff3d5444-a666-4864-aa10-34f607fcd8a3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 844e061a-5160-4cdc-800b-414b0ce9459d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 52e87a3d-f509-46af-8c2e-5e90f87175d8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 95394656-ef39-47a3-8520-65860c572555
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 2d176015-0f1e-4291-93c2-3c0b79277195
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy df1d1683-efa8-4992-8f56-144821d61a0d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit b60de19b-77df-4a26-ad15-556e25306dcf
…

spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 352834f0-9490-4117-b98a-1e28bb7d7a01
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 88ce300c-120d-41c0-8eb5-3da57c83beb8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 7af84c56-2c2f-4ad5-8c9b-20c69a7070e0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 685e1916-a54a-419a-808f-1345c03a0654
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 61341524-804b-4159-8cdd-6b3cb08048aa
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 7c0ccdc8-0bb8-40d8-b96a-ae6f3cd5a831
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 6d0e1849-9b30-44a4-bfb6-3fa5f8a60d2d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update df82c6a8-2903-47d7-9aa2-876259617408
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy b74038d4-8fca-420a-9078-69c08ca97a2f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit d609a109-33d0-48fe-95dd-0818fb3994b7
…

♻️ This comment has been updated with latest results.

@sjproctor
🧹 Updates version of order-already gem
947c483 
This commit updates the version of the order-already gem to 0.3.2. This
version of the gem handles blank values preventing blank fields from
being assigned `[""]` instead of `[]`.

Ref:
- scientist-softserv/adventist_knapsack#771
@sjproctor sjproctor merged commit 8d8e780 into main Sep 19, 2024
8 checks passed
@sjproctor sjproctor deleted the updated-order-already-version branch September 19, 2024 21:19
sjproctor added a commit to scientist-softserv/adventist_knapsack that referenced this pull request Sep 19, 2024
@sjproctor
⚙️ Updates submodule hyrax-webapp
af6eca2 
Updates Hyku main to include the most recent version of the
order_already gem.

Ref:
- samvera/hyku#2334
- #771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangewolf orangewolf orangewolf approved these changes

@ShanaLMoore ShanaLMoore ShanaLMoore left review comments

Assignees
No one assigned
Labels
patch-ver for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjproctor @orangewolf @ShanaLMoore